Ideas Portal

Shutdown of docker should be `stop` not `kill`

  • Steve Hoffman
  • Mar 3 2019
  • Shipped
  • Attach files
  • Steve Hoffman commented
    03 Mar 16:52
    According to the docs [here](https://github.com/storj/storj/wiki/Explorer-Release-Setup-Instructions#upgrading-your-storage-node), you issue a `docker kill` to terminate the storage node. This is akin to `kill -9`. Assuming the docker container does proper shutdown (which it should), a `docker stop` should signal the container to close all resources and exit within the specified time period (defaults to 10 seconds: https://docs.docker.com/engine/reference/commandline/stop/) and then issues a kill if the container fails to exit. Doing a hard shutdown on a storage node seems like the wrong way to go.
  • Admin
    Brandon Iglesias commented
    03 Apr 15:40

    Hey Steve, thank you for the suggestion you are absolutely right, I updated our instructions. https://github.com/storj/docs/blob/master/Explorer-Release-Setup-Instructions.md#upgrading-your-storage-node

    Please keep sending us your ideas and suggestions we appreciate them!